Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: GitHub modal #125

Merged
merged 6 commits into from
Mar 9, 2023
Merged

feat: GitHub modal #125

merged 6 commits into from
Mar 9, 2023

Conversation

lucas-louis
Copy link
Member

@lucas-louis lucas-louis commented Mar 8, 2023 •
edited

Description

Update UI github/ program modals

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@lucas-louis lucas-louis added the enhancement New feature or request label Mar 8, 2023
@lucas-louis lucas-louis self-assigned this Mar 8, 2023
@lucas-louis lucas-louis linked an issue Mar 8, 2023 that may be closed by this pull request
[Feature]: Uniformize the modals #123
Closed
3 tasks
RezaRahemtola
RezaRahemtola approved these changes Mar 9, 2023
View reviewed changes
Copy link
Sponsor Member

@RezaRahemtola RezaRahemtola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the result is awesome 🚀

@lucas-louis lucas-louis changed the title Feat/GitHub modal feat: GitHub modal Mar 9, 2023
@RezaRahemtola RezaRahemtola merged commit 3f72bec into dev Mar 9, 2023
@RezaRahemtola RezaRahemtola deleted the feat/github-modal branch March 9, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RezaRahemtola RezaRahemtola RezaRahemtola approved these changes

Assignees

@lucas-louis lucas-louis

Labels
enhancement New feature or request
Projects
None yet
Milestone
Sprint 7 - Front end uniformization
Development

Successfully merging this pull request may close these issues.

[Feature]: Uniformize the modals
2 participants
@lucas-louis @RezaRahemtola