Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #130

Merged
merged 6 commits into from
Mar 28, 2023
Merged

Code cleanup #130

merged 6 commits into from
Mar 28, 2023

Conversation

RezaRahemtola
Copy link
Sponsor Member

@RezaRahemtola RezaRahemtola commented Mar 19, 2023 •
edited

Description

Code and dependencies cleanup:

  • React and Chakra updated to their latest versions
  • Multiple related fixes (missing keys, useless options)
  • Aleph useless (APIServer which has now a default value) and deprecated (inlineRequested as shown in console warnings) options removed
  • CI updated (caching, flaky test temporarily removed)

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

@RezaRahemtola
deps: react updated to v18
a46cf1a 
chakra updated too
@RezaRahemtola
fix: useless Aleph options removed
c3fc7f4 
Wrong undefined types removed with related checks
@RezaRahemtola RezaRahemtola added enhancement New feature or request dependencies Pull requests that update a dependency file labels Mar 19, 2023
@RezaRahemtola RezaRahemtola self-assigned this Mar 19, 2023
@RezaRahemtola RezaRahemtola force-pushed the feat/cleanup branch 2 times, most recently from 0358481 to a02ef1f Compare March 21, 2023 11:24
@RezaRahemtola RezaRahemtola force-pushed the feat/cleanup branch 8 times, most recently from 114007b to a970225 Compare March 28, 2023 22:49
@RezaRahemtola RezaRahemtola marked this pull request as ready for review March 28, 2023 22:59
@RezaRahemtola RezaRahemtola merged commit 706d043 into dev Mar 28, 2023
@RezaRahemtola RezaRahemtola deleted the feat/cleanup branch March 28, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EdenComp EdenComp Awaiting requested review from EdenComp

@lucas-louis lucas-louis Awaiting requested review from lucas-louis

@SloWayyy SloWayyy Awaiting requested review from SloWayyy

Assignees

@RezaRahemtola RezaRahemtola

Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RezaRahemtola