Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the contact class #145

Merged
merged 12 commits into from
Jun 22, 2023
Merged

Refactor the contact class #145

merged 12 commits into from
Jun 22, 2023

Conversation

sephorah
Copy link
Contributor

@sephorah sephorah commented Jun 5, 2023

Description

We created a class named FullContact, which regroups the classes ContactFile, ContactFolder, Contact, ManageContact and Computing.

Untitled-2023-06-05-2337

We did this because the Contact class was too long and had functions which were not directly related to the Contact class.
ContactFile, ContactFolder and ManageContact have all the functions regarding the files, the folders and the contacts management respectively.

We also moved the Computing class in FullContact.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

src/lib/contact/fullContact.ts Show resolved Hide resolved
src/components/navigation/SideBar.tsx Show resolved Hide resolved
src/components/navigation/ResponsiveBar.tsx Show resolved Hide resolved
src/components/folder/CreateFolder.tsx Show resolved Hide resolved
src/components/file/UpdateContentFile.tsx Show resolved Hide resolved
@RezaRahemtola RezaRahemtola linked an issue Jun 8, 2023 that may be closed by this pull request
7 tasks
@RezaRahemtola RezaRahemtola self-requested a review June 22, 2023 23:25
@RezaRahemtola RezaRahemtola merged commit 25d7562 into dev Jun 22, 2023
3 checks passed
@RezaRahemtola RezaRahemtola deleted the refactor branch June 22, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Uniformise the computing features
3 participants