Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment #1 #56

Merged
merged 9 commits into from
May 21, 2022
Merged

Deployment #1 #56

merged 9 commits into from
May 21, 2022

Conversation

adrienfort
Copy link
Member

@adrienfort adrienfort commented May 19, 2022

Description

Update guiding documents, resolve security dependencies issues and add a multi-stage dockerfile 🚀

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

AmozPay and others added 7 commits April 19, 2022 17:47
Signed-off-by: Amoz Pay <amoz.pay@epitech.eu>
fix: CONTRIBUTING with project name
Bumps [cross-fetch](https://github.com/lquixada/cross-fetch) from 3.1.4 to 3.1.5.
- [Release notes](https://github.com/lquixada/cross-fetch/releases)
- [Commits](lquixada/cross-fetch@v3.1.4...v3.1.5)

---
updated-dependencies:
- dependency-name: cross-fetch
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Amoz Pay <amoz.pay@epitech.eu>
…ss-fetch-3.1.5

build(deps): bump cross-fetch from 3.1.4 to 3.1.5
@adrienfort adrienfort added the documentation Improvements or additions to documentation label May 19, 2022
@adrienfort adrienfort self-assigned this May 19, 2022
@netlify
Copy link

netlify bot commented May 19, 2022

Deploy Preview for nimble-praline-605cf6 ready!

Name Link
🔨 Latest commit 7e3b86f
🔍 Latest deploy log https://app.netlify.com/sites/nimble-praline-605cf6/deploys/6288af41720f0f00086a13e7
😎 Deploy Preview https://deploy-preview-56--nimble-praline-605cf6.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@adrienfort adrienfort added the patch Patch update (for release) label May 19, 2022
Copy link
Sponsor Member

@RezaRahemtola RezaRahemtola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RezaRahemtola
Copy link
Sponsor Member

Looks like there's a dependency problem in the tests.

Copy link
Sponsor Member

@RezaRahemtola RezaRahemtola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Dockerfile Outdated Show resolved Hide resolved
@adrienfort adrienfort merged commit a3ec727 into master May 21, 2022
Copy link
Contributor

@Samoten777 Samoten777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation patch Patch update (for release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants