Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Post messages switched to Aggregate #73

Merged
merged 11 commits into from
Jul 6, 2022

Conversation

RezaRahemtola
Copy link
Sponsor Member

@RezaRahemtola RezaRahemtola commented Jun 30, 2022

Description

Changed the way we interact with Aleph by using aggregate messages instead of posts for optimization and cleanliness purposes.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Breaking changes

This new architecture will make any existing content (file, programs, contacts...) unavailable for all IPC users.

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have added the needed labels
  • I have linked this PR to an issue
  • I have linked this PR to a milestone
  • I have linked this PR to a project
  • I have tested this code
  • I have added / updated tests (unit / functionals / end-to-end / ...)
  • I have updated the README and other relevant documents (guides...)
  • I have added sufficient documentation both in code, as well as in the READMEs

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

@RezaRahemtola RezaRahemtola marked this pull request as ready for review June 30, 2022 20:47
Aggregate message key was created only on signup, now on signup and login if needed
New aggregate types, useToast default params and useless async removed
Checking if ALEPH_CHANNEL is set, throwing an error if unset
Copy link
Member

@lucas-louis lucas-louis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@0xtekgrinder 0xtekgrinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RezaRahemtola RezaRahemtola force-pushed the 70-Feature-Swtich-Post-messages-to-Aggregates branch from d9d7884 to 2c2d788 Compare July 5, 2022 10:11
@RezaRahemtola RezaRahemtola force-pushed the 70-Feature-Swtich-Post-messages-to-Aggregates branch from 92d419c to 1888c48 Compare July 5, 2022 10:39
@RezaRahemtola RezaRahemtola merged commit 586f987 into dev Jul 6, 2022
@RezaRahemtola RezaRahemtola deleted the 70-Feature-Swtich-Post-messages-to-Aggregates branch July 6, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Switch Post messages to Aggregates
8 participants