Linux bugfixes #271
Linux bugfixes #271
Conversation
| this.active = true | ||
| this.bounds = window.bounds() | ||
|
|
||
| const isLinux = process.platform !== ('win32' || 'darwin') |
There was a problem hiding this comment.
I would suggest simply using process.platform === 'linux'
| const text = this.clipboard.readText() | ||
| this.clipboard.writeText(command.text) | ||
| await sleep(75) |
There was a problem hiding this comment.
Why not use delay instead of await and making this async?
Maybe a broader question, looking at the changes, why not increase the keyboard delay (using setKeyboardDelay) itself? As it looks like Linux has trouble with keys being tapped too fast, you could perhaps consider making this platform specific too. This way the behaviour for Windows users, who have no problems with the shorter delay, won't see any behavioral changes. Especially since an additional 150ms will be noticable on Windows.
|
|
||
| const windowPath = path.parse((window.path || '').toLowerCase()) | ||
|
|
||
| if (POE_NAMES.includes(windowPath.base)) { |
There was a problem hiding this comment.
Since you're using path.parse anyway, the POE_NAMES could probably benefit from an optimization too by removing all .exe names, and using windowPath.name instead of the .base
|
Any hope for this getting merged? I'm having a hard time getting this to work on Linux, I'd love to see a bit more Linux support. |
Description
Multiple bugfixes for linux :
How Has This Been Tested?
npm run ng:lintnpm run formatnpm run ng:test