fix(tests): making the tests not change the time

Pocket · Apr 17, 2024 · 102f844 · 102f844
1 parent 73f4a64
commit 102f844
Show file tree

Hide file tree

Showing 14 changed files with 182 additions and 16 deletions.
diff --git a/servers/list-api/src/test/graphql/mutations/clearTags.integration.ts b/servers/list-api/src/test/graphql/mutations/clearTags.integration.ts
@@ -36,7 +36,16 @@ describe('clearTags mutation', () => {
   beforeAll(async () => {
     jest.useFakeTimers({
       now: now,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
     });
     ({ app, server, url } = await startServer(0));
   });

diff --git a/servers/list-api/src/test/graphql/mutations/replaceTags.integration.ts b/servers/list-api/src/test/graphql/mutations/replaceTags.integration.ts
@@ -36,7 +36,16 @@ describe('clearTags mutation', () => {
   beforeAll(async () => {
     jest.useFakeTimers({
       now: now,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
     });
     ({ app, server, url } = await startServer(0));
   });

diff --git a/servers/list-api/src/test/graphql/mutations/savedItemById/reAdd.integration.ts b/servers/list-api/src/test/graphql/mutations/savedItemById/reAdd.integration.ts
@@ -35,7 +35,19 @@ describe('reAddById mutation', () => {
 
   beforeAll(async () => {
     ({ app, server, url } = await startServer(0));
-    jest.useFakeTimers({ advanceTimers: true, now });
+    jest.useFakeTimers({
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
+      now,
+    });
   });
 
   afterAll(async () => {

diff --git a/.../src/test/graphql/mutations/savedItemById/savedItemsMutationService-delete.integration.ts b/.../src/test/graphql/mutations/savedItemById/savedItemsMutationService-delete.integration.ts
@@ -127,7 +127,16 @@ describe('Delete/Undelete SavedItem: ', () => {
     // Mock Date.now() to get a consistent date for inserting data
     jest.useFakeTimers({
       now: updateDate,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
     });
   });
 

diff --git a/.../src/test/graphql/mutations/savedItemById/savedItemsMutationService-upsert.integration.ts b/.../src/test/graphql/mutations/savedItemById/savedItemsMutationService-upsert.integration.ts
@@ -68,7 +68,19 @@ describe('UpsertSavedItem Mutation', () => {
 
   beforeAll(async () => {
     ({ app, server, url } = await startServer(0));
-    jest.useFakeTimers({ advanceTimers: true, now: dateNow });
+    jest.useFakeTimers({
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
+      now: dateNow,
+    });
   });
 
   afterAll(async () => {
@@ -438,7 +450,19 @@ describe('UpsertSavedItem Mutation', () => {
     });
 
     it('should push addItem event to perm lib queue for premium users', async () => {
-      jest.useFakeTimers({ advanceTimers: true, now: dateNow });
+      jest.useFakeTimers({
+        doNotFake: [
+          'nextTick',
+          'setImmediate',
+          'clearImmediate',
+          'setInterval',
+          'clearInterval',
+          'setTimeout',
+          'clearTimeout',
+        ],
+        advanceTimers: false,
+        now: dateNow,
+      });
       const variables = {
         url: 'http://addingtoqueue.com',
       };
@@ -517,7 +541,19 @@ describe('UpsertSavedItem Mutation', () => {
       });
 
       it(`should update an item already in a user's list`, async () => {
-        jest.useFakeTimers({ advanceTimers: true, now: dateNow });
+        jest.useFakeTimers({
+          doNotFake: [
+            'nextTick',
+            'setImmediate',
+            'clearImmediate',
+            'setInterval',
+            'clearInterval',
+            'setTimeout',
+            'clearTimeout',
+          ],
+          advanceTimers: false,
+          now: dateNow,
+        });
         const variables = {
           url: 'http://google.com',
           isFavorite: true,

diff --git a/...c/test/graphql/mutations/tagsById/tagsMutationService-replaceSavedItemTags.integration.ts b/...c/test/graphql/mutations/tagsById/tagsMutationService-replaceSavedItemTags.integration.ts
@@ -28,7 +28,16 @@ describe('tags mutation: replace savedItem tags', () => {
     // Mock Date.now() to get a consistent date for inserting data
     jest.useFakeTimers({
       now: updateDate,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
     });
   });
 

diff --git a/...rs/list-api/src/test/graphql/mutations/tagsById/tagsMutationService-update.integration.ts b/...rs/list-api/src/test/graphql/mutations/tagsById/tagsMutationService-update.integration.ts
@@ -40,7 +40,16 @@ describe('updateTag Mutation: ', () => {
   beforeEach(async () => {
     jest.useFakeTimers({
       now: updateDate,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
     });
     jest.clearAllMocks();
     const baseTag = {

diff --git a/...rc/test/graphql/mutations/tagsById/tagsMutationService-updateSavedItemTags.integration.ts b/...rc/test/graphql/mutations/tagsById/tagsMutationService-updateSavedItemTags.integration.ts
@@ -42,7 +42,17 @@ describe('tags mutation update: ', () => {
     // Mock Date.now() to get a consistent date for inserting body.data
     jest.useFakeTimers({
       now: updateDate,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
+      s,
     });
     await writeDb('item_tags').truncate();
     await writeDb('item_tags').insert([

diff --git a/servers/list-api/src/test/graphql/mutations/tagsByName/deleteTagByName.integration.ts b/servers/list-api/src/test/graphql/mutations/tagsByName/deleteTagByName.integration.ts
@@ -32,7 +32,16 @@ describe('deleteTagByName mutation', () => {
   beforeAll(async () => {
     jest.useFakeTimers({
       now: now,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
     });
     ({ app, server, url } = await startServer(0));
   });

diff --git a/servers/list-api/src/test/graphql/mutations/tagsByName/renameTagByName.integration.ts b/servers/list-api/src/test/graphql/mutations/tagsByName/renameTagByName.integration.ts
@@ -36,7 +36,16 @@ describe('deleteTagByName mutation', () => {
   beforeAll(async () => {
     jest.useFakeTimers({
       now: now,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
     });
     ({ app, server, url } = await startServer(0));
   });

diff --git a/servers/user-api/src/events/eventBus/eventBusHandler.spec.ts b/servers/user-api/src/events/eventBus/eventBusHandler.spec.ts
@@ -36,7 +36,16 @@ describe('EventBusHandler', () => {
   beforeAll(() => {
     jest.useFakeTimers({
       now: now,
-      advanceTimers: true,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
     });
   });
 

diff --git a/servers/user-list-search/src/freeSearch.integration.ts b/servers/user-list-search/src/freeSearch.integration.ts
@@ -101,7 +101,19 @@ describe('free search test', () => {
   });
 
   beforeEach(async () => {
-    jest.useFakeTimers({ now: updateDate, advanceTimers: true });
+    jest.useFakeTimers({
+      now: updateDate,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
+    });
   });
 
   afterAll(async () => {

diff --git a/servers/user-list-search/src/freeSearchByOffset.integration.ts b/servers/user-list-search/src/freeSearchByOffset.integration.ts
@@ -105,7 +105,19 @@ describe('free-tier search (offset pagination)', () => {
   });
 
   beforeEach(async () => {
-    jest.useFakeTimers({ now: updateDate, advanceTimers: true });
+    jest.useFakeTimers({
+      now: updateDate,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
+    });
   });
 
   afterAll(async () => {

diff --git a/servers/v3-proxy-api/src/routes/v3Send.integration.ts b/servers/v3-proxy-api/src/routes/v3Send.integration.ts
@@ -23,7 +23,19 @@ describe('v3/send', () => {
     clientSpy = jest
       .spyOn(GraphQLClient.prototype, 'request')
       .mockResolvedValue(true);
-    jest.useFakeTimers({ now: now * 1000, advanceTimers: true });
+    jest.useFakeTimers({
+      now: now * 1000,
+      doNotFake: [
+        'nextTick',
+        'setImmediate',
+        'clearImmediate',
+        'setInterval',
+        'clearInterval',
+        'setTimeout',
+        'clearTimeout',
+      ],
+      advanceTimers: false,
+    });
   });
   afterAll(async () => {
     clientSpy.mockRestore();