Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps)!: Version 3.0.0 #18

Merged
merged 14 commits into from
Sep 27, 2023
Merged

chore(deps)!: Version 3.0.0 #18

merged 14 commits into from
Sep 27, 2023

Conversation

cfpinto
Copy link
Contributor

@cfpinto cfpinto commented Sep 11, 2023 •
edited by clemblanco
Loading

  • migrated to aws-sdk v3
  • migrated tslint to eslint, tslint is now deprecated
  • upgrade all dependencies
  • added basic prettier

BREAKING CHANGE: aws-sdk v3 upgrade

clemblanco
clemblanco reviewed Sep 11, 2023
View reviewed changes
Copy link

@clemblanco clemblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just a few questions/comments. 👍

src/__tests__/http/Repository.test.ts Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.eslintrc.js Outdated Show resolved Hide resolved
.prettierrc.json Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
src/__mocks__/aws-sdk.ts Outdated Show resolved Hide resolved
src/logs/Service.ts Outdated Show resolved Hide resolved
src/logs/Service.ts Show resolved Hide resolved
src/notifications/Notification.ts Show resolved Hide resolved
src/notifications/Notification.ts Show resolved Hide resolved
clemblanco
clemblanco approved these changes Sep 18, 2023
View reviewed changes
Copy link

@clemblanco clemblanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one. Might experience some teething issues when trying to release from GHA for the first time here.

@clemblanco clemblanco changed the title chore(deps): Version 3.0.0 chore(deps)!: Version 3.0.0 Sep 27, 2023
@clemblanco clemblanco merged commit a47ccc4 into master Sep 27, 2023
3 checks passed
@clemblanco clemblanco deleted the version-3.0.0 branch September 27, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemblanco clemblanco clemblanco approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cfpinto @clemblanco