Add WebSub push support #379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide a basic pingServices() function whose job will be to call the functions which actually ping each individual service.
With the lone exception of the cron update of the RSS, since we should only ping services when we know something has actually changed (or the admin fakes it explicitly).
This page will host configuration settings for integrated services.
Provide a default WebSub hub for new sites, and simply add the setting itself without a value for upgrades so that existing users can decide whether or not to use WebSub pushes.
This adds a function to send a WebSub publish message to the configured server, and adds that function to the pingServices() function so it will be called whenever the podcast updates.
There's no point in sending WebSub messages to a hub if subscribers to the podcast cannot subscribe via the hub. Add a link in the RSS feed that points clients towards the hub that we are using for pushing update messages.
That was a dumb typo.
coldacid
force-pushed
the
websub-push
branch
from
a2669ac
to
e01ef66
Compare
emilengler
requested changes
Jan 29, 2021
Since there aren't any other third-party integrations in place at this time, we'll keep things in pg_config.php and revert this particular commit when adding in other integrations.
coldacid
force-pushed
the
websub-push
branch
2 times, most recently
from
3589db1
to
00a137b
Compare
emilengler
requested changes
Feb 2, 2021
emilengler
requested changes
Feb 2, 2021
|
Btw there is still one thing to note! Could you add a function_exists before a curl function and exit if it is not found? I don't want another php dependency, in this case php-curl. See: https://www.php.net/manual/en/function.function-exists.php |
Check for the curl_init function. If it exists, so do curl_setopt, curl_exec, and curl_close. curl_setopt_array exists in PHP 5.1.3 when cURL is available from PHP, but not in earlier versions; iterate the options array when this is the case.
|
Okay, I'm checking for the cURL module now. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to announce updates to a WebSub server, and reference that server in the RSS feed so that the podcast listeners can subscribe for updates via the WebSub protocol. This also lays out infrastructure for adding additional services such as Podcast Index.
For details, see https://podnews.net/article/pubsubhubbub-for-podcasters