Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions do not match: Cargo, HTML, Git Tag, Github Release #18

Open
valcanobacon opened this issue Jan 11, 2022 · 3 comments
Open

Versions do not match: Cargo, HTML, Git Tag, Github Release #18

valcanobacon opened this issue Jan 11, 2022 · 3 comments

Comments

@valcanobacon
Copy link
Contributor

The Release Version does not match the versions in Cargo and HTML.

An MR can be opened to fix it this time but I am interested in ways to automate this.

@valcanobacon valcanobacon changed the title Versions do not match: Cargo, HTML, and Git Tag Versions do not match: Cargo, HTML, Git Tag, Github Release Jan 11, 2022
@daveajones
Copy link
Contributor

Oversight on my part. I'd be interested in an automated way to do it as well. Thanks for bringing this up.

@valcanobacon
Copy link
Contributor Author

I don't think there is anyway to avoid updating Cargo.toml. The value in the html can be turned into a variable that could be taken from the current value in the Cargo.toml. We could write a release script that adds a bump commit before a it tags, pushes and creates the release. This script might be helpful but does not solve the issue. Perhaps we can have a Github Action which hooks on to the Release Creation and checks if the versions are correct. Maybe whenever we merge to master/main a action is triggered, if the tests pass (version is good), then publish the release. Could be published as a draft which would allow you to edit the description before publishing.

@daveajones
Copy link
Contributor

Yeah, I think an action that just generates an alert is fine.

valcanobacon added a commit to valcanobacon/helipad that referenced this issue Jan 23, 2022
valcanobacon added a commit to valcanobacon/helipad that referenced this issue Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants