Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR: use exclamation mark on functions throwing errors #103

Open
sigu opened this issue Mar 26, 2019 · 0 comments · May be fixed by #147
Open

REFACTOR: use exclamation mark on functions throwing errors #103

sigu opened this issue Mar 26, 2019 · 0 comments · May be fixed by #147
Assignees
@75pollet
Labels
review
Milestone
registrations

Comments

@sigu
Copy link
Member

sigu commented Mar 26, 2019

If you are using a function that throws an error when no result is found in ecto, by convention the function should have an exclamation mark at the end of it.

This resolves this comment on this PR
@sigu sigu added this to the registrations milestone Mar 26, 2019
@sigu sigu mentioned this issue Mar 26, 2019
Closed
@75pollet 75pollet linked a pull request Apr 4, 2019 that will close this issue
Open
3 tasks
@sigu sigu added the review label Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@75pollet 75pollet

Labels
review
Projects
None yet
Milestone
registrations
Development

Successfully merging a pull request may close this issue.

remove exclamation mark Podiihq/nailinda
2 participants
@sigu @75pollet