Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

date of birth should be less than date.now #127

Closed
GettyOrawo opened this issue Apr 1, 2019 · 3 comments · Fixed by #129
Closed

date of birth should be less than date.now #127

GettyOrawo opened this issue Apr 1, 2019 · 3 comments · Fixed by #129
Assignees
@misswayua

Comments

@GettyOrawo
Copy link
Contributor

No description provided.

@sandeshsoni
Copy link
Contributor

@GettyOrawo can I help with this issue? I will open a PR

@GettyOrawo
Copy link
Contributor Author

Hey @sandeshsoni Yes sure. Thanks! We love open source contributors. Just create a PR using the template provided and work on it! 🙂

@sandeshsoni
Copy link
Contributor

sandeshsoni commented Apr 1, 2019 •
edited
Loading

hey @GettyOrawo I am close to fixing this issue and open a PR.
sandeshsoni@7b8c9fb

The problem right now is, if we provide nil DateOfBirth, it still tries to validate if its future date and throws error. Debugging. Ideally it should not.

@sandeshsoni sandeshsoni mentioned this issue Apr 1, 2019
Merged
3 tasks
@misswayua misswayua mentioned this issue Apr 2, 2019
Closed
3 tasks
@sigu sigu added the review label Apr 2, 2019
@sigu sigu removed the review label Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@misswayua misswayua

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@sigu @sandeshsoni @GettyOrawo @misswayua