Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows gradle commands support, VSCode launch.json for placing debug points, and minor doc update #2

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

ambaumann
Copy link
Contributor

This is a mix of small changes for me to get to a build and debug workflow on windows.

  • Im newer to gradle, electron, and rollup so any direction on adjusting this PR is welcome.
  • Building the source maps through rollup might need to be made contextual but were needed to place VSCode debug points.
  • For the VSCode debug profiles, I used: Online Example
  • I tested that debug points can be set for the echo app both in the main and the tsx files.
  • It is a bit annoying that Windows cant use npm without the "CMD" extension by default.
  • The existing package locks were giving me grief specifically with "Error: Cannot find module '@rollup/rollup-win32-x64-msvc'". Maybe it had to do with 4.1.4 vs 4.1.5 on windows. I just regenerated new package lock files. For some reason the license info in the lock files was dropped. Let me know if I need to regenerate them or if there is more detail on how existing lock files are generated.

"@rollup/rollup-linux-x64-musl": "4.1.5",
"@rollup/rollup-win32-arm64-msvc": "4.1.5",
"@rollup/rollup-win32-ia32-msvc": "4.1.5",
"@rollup/rollup-win32-x64-msvc": "4.1.5",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This difference might be the most impacting one for me to get a working build.

@ambaumann
Copy link
Contributor Author

Debug profiles made available: image

Breakpoint in main:
image

Debug point in rendered typescript:
image

@zach-herridge
Copy link
Member

This looks good overall, glad to see you were able to get a windows build working. I'll test it later today and get it merged. The lock files are probably not a big deal but I can test it on a few more systems to make sure.

@zach-herridge zach-herridge merged commit 69acd68 into PoeStack:main Nov 3, 2023
avidreder referenced this pull request in avidreder/poestack-sage Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants