Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shadcn components structure, and created action-tooltip component #51

Merged
merged 7 commits into from
Nov 24, 2023

Conversation

kongsgaard
Copy link

Added support for Shadcn, and setup a tooltip component.
now_with_tooltip

Wrt. the app.css and tailwind.config.js i added all the recommended styles from shadcn, but we should probably filter down which color schemes we want to support. If we don't go with the default names, we have to rename color-tokens after a new component is imported, which is probably fine.

@C3ntraX
Copy link
Contributor

C3ntraX commented Nov 24, 2023

Can we add a gradient theme color? Its the only additional variable created by the theme generator I linked

@C3ntraX
Copy link
Contributor

C3ntraX commented Nov 24, 2023

Additional, we should remove the old variables. Because the new variables will cover it. Look at the theme generator, these colors are overhead and means that its harder to add additional themes via the generator

@kongsgaard kongsgaard marked this pull request as ready for review November 24, 2023 08:09
Copy link
Member

@zach-herridge zach-herridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, if we can resolve the merge conflict I'll merge it

@kongsgaard
Copy link
Author

Should be good to go, but i can't merge

@zach-herridge zach-herridge merged commit f27fe82 into PoeStack:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants