Stop looping if section number isn't positive #112
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We experienced a glitch which caused the section number to become negative. This spawned millions of errors as the loop continued to attempt to calculate the questionsbysec for a negative section number.
|
I am deferring this until the latest feature code has been completed. |
|
Hi. There has been a lot of restructuring of the code in the 3.4 branch (not yet merged into the master branch) that may or may not fix this issue. In any case, this change is no longer relevant. Can you review the new code and if there is still an issue, resubmit a new PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We experienced a glitch which caused the section number to become
negative. This spawned millions of errors as the loop continued to
attempt to calculate the questionsbysec for a negative section number.