Replace usages of math.exp2 on python older than 3.11 #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngoldbaum
changed the title
Signed-off-by: Nathan Goldbaum <nathan.goldbaum@gmail.com>
It does run, but We can consider running tests against the oldest supported python version for PRs separately from this. |
timkpaine
approved these changes
Mar 13, 2024
robambalu
reviewed
Mar 13, 2024
| @@ -363,7 +364,10 @@ def comp(x: ts["T"]): | |||
| log2 = define_unary_op("log2", lambda x: math.log2(x)) | |||
| log10 = define_unary_op("log10", lambda x: math.log10(x)) | |||
| exp = define_unary_op("exp", lambda x: math.exp(x)) | |||
| exp2 = define_unary_op("exp2", lambda x: math.exp2(x)) | |||
| if sys.version_info < (3, 11): | |||
There was a problem hiding this comment.
do we really need this version check? Just use 2**x
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes
test_sdistfail on a "full" test run: https://github.com/ngoldbaum/csp/actions/runs/8269123488/job/22623671505I'm not sure offhand why
test_math_unary_opsdoesn't run in the regular tests.