You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
On Windows, running find_package( PCL 1.12.1 REQUIRED ) in a downstream CMake project produces invalid Boost preprocessors in MSVS: BOOST_ALL_NO_LIB-DBOOST_ALL_NO_LIB
It's very simple to fix this issue manually.
I'm not sure if this is simply a result of my environment.
Environment
OS: Windows 10,Pro 19044.1526
Microsoft Visual C++ 14.29
PCL Version 1.12.1
To Reproduce:
(1) download PCL 1.12.1 Windows installer; (2) run simple downstream CMake project:
It may be a problem with the Boost upgrade. This problem does not occur in PCL 1.11 with Boost 1.74.0 linked.
It seems that we have to do something support to new Boost (at least it seems so Boost 1.78). @kunaltyagi@larshg Can anyone investigate this issue? Thanks,
It is very time consuming to investigate which version contains the problem. Therefor, I propose the following workaround.
It only adds BOOST_ALL_NO_LIB at the first time.
- if(WIN32 AND NOT MINGW)+ if(WIN32 AND NOT MINGW AND NOT "${BOOST_DEFINITIONS}" MATCHES "BOOST_ALL_NO_LIB")
string(APPEND BOOST_DEFINITIONS -DBOOST_ALL_NO_LIB)
endif()
The preprocessor macros defined by this workaround are as follows. There seems to be no problem.
On Windows, running
find_package( PCL 1.12.1 REQUIRED )
in a downstream CMake project produces invalid Boost preprocessors in MSVS:BOOST_ALL_NO_LIB-DBOOST_ALL_NO_LIB
It's very simple to fix this issue manually.
I'm not sure if this is simply a result of my environment.
Environment
To Reproduce:
(1) download PCL 1.12.1 Windows installer; (2) run simple downstream CMake project:
It looks like this line is problematic with find_boost, and it is getting called numerous times:
pcl/PCLConfig.cmake.in
Line 110 in a26f6d4
PCL 1.12.1 full list of preprocessors:
PCL 1.12.0 full list of preprocessors (for reference):
Troubleshooting
Replacing
pcl/PCLConfig.cmake.in
Line 110 in a26f6d4
with
string(APPEND BOOST_DEFINITIONS " -DBOOST_ALL_NO_LIB")
still produces an invalid preprocessor:The text was updated successfully, but these errors were encountered: