Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TMB plot (tcgaCompare): Burden changes depending on input order #1018

Open
FriederikeHanssen opened this issue May 2, 2024 · 2 comments
Open
Labels

Comments

@FriederikeHanssen
Copy link

FriederikeHanssen commented May 2, 2024

Describe the issue
I am using the funciton tcgaCompare. Depending on the whether I plot each of my cohorts individually or add them all to one tcgaCompare plot, the results change.

Command
Please post your commands and the output (errors or any unexpected output)

Plot A (both):

tumor_mutational_burden <- tcgaCompare(
                               maf = c( mafs_wes,mafs_overlap),
                               capture_size = c(capture_size_wes,capture_size_overlap),
                               cohortName = c( "WES","Overlap )
                                )
tumor_mutational_burden

Plot B (one only):

tumor_mutational_burden <- tcgaCompare(mafs_wes, capture_size = capture_size_wes )
tumor_mutational_burden

Session info
Run sessionInfo() and post the output below

karyoploteR       regioneR  GenomicRanges   GenomeInfoDb        IRanges      S4Vectors   BiocGenerics 
      "1.28.0"       "1.34.0"       "1.54.1"       "1.38.1"       "2.36.0"       "0.40.2"       "0.48.1" 
        ggpubr        ggplot2      gridExtra          tidyr          dplyr ComplexHeatmap     kableExtra 
       "0.6.0"        "3.5.1"          "2.3"        "1.3.1"        "1.1.4"       "2.18.0"        "1.3.4" 
         knitr        cowplot        forcats      patchwork       maftools 
        "1.45"        "1.1.3"        "1.0.0"        "1.1.3"       "2.18.0" 

B
A

PoisonAlien added a commit that referenced this issue May 5, 2024
@PoisonAlien
Copy link
Owner

Hi,
Thank you for the issue. It was indeed a bug - all the input MAFs were being normalized with the first capture_size.
I have fixed it. Please let me know if it works for you.

Copy link

github-actions bot commented Jul 5, 2024

This issue is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale label Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants