Profiles 2: Electric Boogaloo #2535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The extraListener is now an interface Co-authored-by: SerpentSpirale <mathiasboulay@free.fr>
- Removed profiles fragment because Serpent begged me not to use viewpager - Progressed further with the profiles dialog, now it's actually usable - Now launcher doesn't have profile amnesia - More splitting of raw version selector and profile selector Bugs: - Saving profiles in the editor does nothing TODO: - Implement launching the game with selected profile - Replace "Unknown" version ID in profiles with mProfile.selectedVersion for ease of migration
Co-authored-by: SerpentSpirale <serpentspirale@gmail.com>
* Extended MCOptionUtils to support list values * Mitigation for the Apache Log4j RCE in 1.8.x-1.18 Related issue: #2378 * Update JREUtils.java Co-authored-by: SerpentSpirale <mathiasboulay@free.fr> Co-authored-by: Duy Tran Khanh <40482367+khanhduytran0@users.noreply.github.com>
* Extended MCOptionUtils to support list values * Mitigation for the Apache Log4j RCE in 1.8.x-1.18 Related issue: #2378 * Update JREUtils.java * Completely fix Log4J RCE (1.7-1.16.5) (not yet tested) #2378 * fix moment * Fix a NullPointerException when launching ≤ 1.6.4 * Updated virgl vtest (arm64 only) Experimental changes: - HACK: explicitly set location for fsout_c0/1. this might not work, not tested - Fix empty screen on OF + shader: caused by target fb/texture changed * Trigger a texture creation, which then set VIRGL_TEXTURE_ID * Replace sprintf with asprintf for auto allocation * Update egl_bridge.c * Updated vtest lib: fixes flipped screen * CI: Update gl4es * Updated vtest arm64: fixes black screen on <1.13(?) Co-authored-by: SerpentSpirale <mathiasboulay@free.fr> Co-authored-by: Duy Tran Khanh <40482367+khanhduytran0@users.noreply.github.com> Co-authored-by: khanhduytran0 <khanhduytran0@users.noreply.github.com> Co-authored-by: github-actions <github-actions@users.noreply.github.com>
…to profiles-2-electric-boogaloo
* add Arc capes DNS injector * Bug fix: Arc DNS injector breaks on Java 17 Error: Failed to inject cache! java.lang.reflect.InaccessibleObjectException: Unable to make java.net.InetAddress$CachedAddresses(java.lang.String,java.net.InetAddress[],long) accessible: module java.base does not "opens java.net" to unnamed module @4157f54e * Validate assets even if it’s fully downloaded (#2730) * Update MinecraftDownloaderTask.java Co-authored-by: Duy Tran Khanh <40482367+khanhduytran0@users.noreply.github.com>
|
profiles my beloved |
Merge and resolve conflicts
- Force profiles, no more profiles on/off switch! - (probably partially) Conventionalize all profile changes - Rename most variables for the changes to look nice - Squash a couple null checks - Separate cache from adapter and change how it works - Don't keep Context
…hods and sanitize the code according to serpent's recommendations
|
Please add a customisable game directory |
Move all ExtraCore constants into a separate class
Add the 3rd constant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Mojang's Launcher Profiles into the launcher, along with some features they carry.
Right now, it's mainly used just to do mergeability tracking, but it will be merged once its done.