Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GL4ES: HOLY EDITION #3019

Merged
merged 34 commits into from
Apr 16, 2022
Merged

GL4ES: HOLY EDITION #3019

merged 34 commits into from
Apr 16, 2022

Conversation

Mathias-Boulay
Copy link
Contributor

@Mathias-Boulay Mathias-Boulay commented Apr 3, 2022

GL4ES: HOLY EDITION 🌠

Ladies and gentlemen, entities of the internet, TODAY we are here to celebrate the arrival of the one and only: GL4ES - HOLY EDITION !
"Why ?" I hear you ask ? Simple my child, simple really.

Native 1.17+ support

Turns out that I could just apply some of my shader convertion tricks, such as:

  • Avoid scalar type implicit conversion by making everything a float 🔫
  • Add "%" operator support, by "just" getting both operands and making them go through a function
  • Wrapping some functions and layout binding logic

Yes, this does require opengles 3.0 + to properly work. Older devices, if they can stomach those versions at all, will still require the patch.

1.7.10 crash fix

Oh yeah, remember this issue from v3.3.1.1 ?
Thanks to the blessing of this 👼holy👼 version, the crashing is no more.
Also it was due to an issue with testing the sizeof() an int instead of a byte

Older versions QoL

Since older versions fare much better with openGL 1 (avoids crashes and "halved lighting" issues), some auto detection is added into the launcher to select the appropriate opengl version for you.
Note: I'm aware that some modded old versions cannot be detected.

Miscenalleous

Less impressive changes, although noteworthy ones are:

  • The profile migrator now avoid useless migrations, and takes into account the older vulkan based renderer
  • Some devices were improperly reporting the display size, causing a control offset and slightly distorting minecraft, this has been fixed.
  • Sometimes, the remove notch option was available despite the device being notchless.
  • The CI is updated to avoid the gplay part being executed when a PR is made, to avoid the integration failing
  • The CI is updated to use the latest gl4es 🌠HOLY👼 edition instead
  • The CI is updated not to use vgpu ever again.
  • Removed the experimental fuckuries, there are kinda useless now.
  • Hey, the build size has been trimmed as a result of less renderers !

@NotAHero04
Copy link
Contributor

How holy

@kuzy21
Copy link

kuzy21 commented Apr 4, 2022

I KNEW IT ITZ HOLY HOLY HOLLYYY

Change gl4es to gl4es_extra;
Build and upload .aab file only on push on mainline;
@CriticalRange
Copy link
Contributor

Holy moly macaroni

@kuzy21
Copy link

kuzy21 commented Apr 5, 2022

HOLLY I SAY HOLYYYYYY THE GODSSSS HAVVEVEVEV BLESSSS USSSSS SEE

@offbeat-stuff
Copy link

Does it mean performace improvements on gles 3.0

@TWTommyee
Copy link

Oh mai gawd

@CriticalRange
Copy link
Contributor

It's broken guys

I don't see any problem, maybe related to your device ?

@offbeat-stuff
Copy link

vanilla works but it does not to convert other shaders like from sodium

@offbeat-stuff
Copy link

It's broken guys

You need opengles 3.0 to run the game perfectly

@FrostNovaHD
Copy link
Contributor

vanilla works but it does not to convert other shaders like from sodium

use optifine optifine works

@FrostNovaHD
Copy link
Contributor

It's broken guys

You need opengles 3.0 to run the game perfectly

not really because optifine runs

@offbeat-stuff
Copy link

It's broken guys

You need opengles 3.0 to run the game perfectly

not really because optifine runs

It is written in the pr description that you need opengles 3.2 to run the game perfectly otherwise you need the assets-v0 file

@FrostNovaHD
Copy link
Contributor

It's broken guys

You need opengles 3.0 to run the game perfectly

not really because optifine runs

It is written in the pr description that you need opengles 3.2 to run the game perfectly otherwise you need the assets-v0 file

yes most phones have opengl es 3.2

@offbeat-stuff
Copy link

but not every phone has gles 3.2

@offbeat-stuff
Copy link

So would there be support for converting shaders loaded by sodium??

@TWTommyee
Copy link

Why you must use sodium? There's other excellent fabric optimization mods too, also even optifabtic works now

@offbeat-stuff
Copy link

Bro nothing comes close to what sodium does

@offbeat-stuff
Copy link

And sodium is the only rendering optimization mod on fabric, optifine is bloat.

@TWTommyee
Copy link

Starlight, entityculling, lithium, better fps mod and more, not only sodium

@offbeat-stuff
Copy link

they optimize game logic not the rendering

@offbeat-stuff
Copy link

I changed sodium shaders but it seems to get cut off after some code leading to ";" token expected error

@offbeat-stuff
Copy link

latestlog.txt
Here is the log with the shader included

@offbeat-stuff
Copy link

I tried vanilla shader code, simple glShaderSource,
and the normal sodium
same error
tried to delete comments remove lines it just changed the line number of the error

@artdeell artdeell merged commit ab6df38 into v3_openjdk Apr 16, 2022
@artdeell artdeell deleted the holy_gl4es_extra branch May 1, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants