Color selector #3120
Merged
Color selector #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added side by side (alpha, non-alpha color view) Removed "tapping" from all listeners (since it became pointless) Now all listeners don't fire events when the values are set programmatically Remove unneeded logging Clean up typos
Other changes: The ColorSelectionListener is back! Now ColorSelector.runColor(int) is used for unified initialization Added invalidate flag into SVRectangleView.setColor() to avoid a useless invalidation in runColor() Moved repeating Color.HSVtoColor into ColorSelector.dispatchColorChange() Fixed a bug: mAlphaSelected wasn't set to the appropriate value by runColor, leading to the Color Preview and HEX edit breaking in some cases
Added access modifiers (why :despair:) Moved the cast Added error reporting if the tex in the HEX edit box is not a valid HEX value (by making the text red)
|
Seems good enough to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's (probably) done! Now we can remove the color selector dependency!