Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dind version to match CircleCI Docker version #30

Merged
merged 2 commits into from
Apr 28, 2020
Merged

Fix dind version to match CircleCI Docker version #30

merged 2 commits into from
Apr 28, 2020

Conversation

Naramsim
Copy link
Member

@Naramsim Naramsim commented Apr 25, 2020 •
edited

CircleCI uses Docker 18.09.3

https://circleci.com/docs/2.0/configuration-reference/#available-machine-images

Dind only works when deployed on the same version engine. So we should ensure we are using 18.09.3

@Naramsim Naramsim requested review from Kronopt and a team April 25, 2020 17:27
@Naramsim Naramsim merged commit 3689e42 into master Apr 28, 2020
@Naramsim Naramsim deleted the test branch April 28, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phalt phalt phalt approved these changes

@Kronopt Kronopt Awaiting requested review from Kronopt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Naramsim @phalt