Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circle ci deploy #36

Merged
merged 7 commits into from
Apr 26, 2020
Merged

Circle ci deploy #36

merged 7 commits into from
Apr 26, 2020

Conversation

Naramsim
Copy link
Member

No description provided.

@Naramsim Naramsim requested a review from cmmartti April 26, 2020 17:37
@Naramsim
Copy link
Member Author

We can squash

@Naramsim Naramsim merged commit b095782 into master Apr 26, 2020
@Naramsim Naramsim deleted the circle-ci-deploy branch April 26, 2020 17:41
@Naramsim
Copy link
Member Author

@Naramsim
Copy link
Member Author

Naramsim commented Apr 26, 2020

What I fear now is that maybe pushing to branches other than master will generate new jobs and those jobs will be marked as latest and will not carry any artifacts.

I'll try to push a new branch just to check

@cmmartti
Copy link
Member

Could we use GitHub Actions for this instead? It wasn't public when we first set up CircleCI, and it might make things easier. I've never used it, so I don't know.

@Naramsim
Copy link
Member Author

Ok, pushing to new branches doesn't change the latest artifact on this URL: https://circleci.com/api/v1.1/project/github/PokeAPI/api-data/latest/artifacts?branch=master so the querystring works well.

Could we use GitHub Actions for this instead? It wasn't public when we first set up CircleCI, and it might make things easier. I've never used it, so I don't know.

In my opinion, we should stick for now with CircleCI. We use it on all the projects and now works well. In a few days (when I will open the definitive PR) we will also have the updater bot running there. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants