Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's no flag to say if the pkmn is a ultra beast #482

Closed
leobetosouza opened this issue Apr 6, 2020 · 2 comments
Closed

There's no flag to say if the pkmn is a ultra beast #482

leobetosouza opened this issue Apr 6, 2020 · 2 comments

Comments

@leobetosouza
Copy link

leobetosouza commented Apr 6, 2020

Ultra beasts are a special kind of Pokémon debuted in Pokémon Sun and Moon. More info: https://bulbapedia.bulbagarden.net/wiki/Ultra_Beast

For example, Naganadel.
Pokémon: https://pokeapi.co/api/v2/pokemon/804/
Specie: https://pokeapi.co/api/v2/pokemon-species/804/
Form: https://pokeapi.co/api/v2/pokemon-form/804/

Neither as a attribute that indicates it is a ultra beast, like is_baby (in the specie endpoint) or is_mega (in the form endpoint)... is_ultra_beast isn't a bad one.

Currently the only know way to say if the pokémon is a ultra beast is checking the ability Beast Boost. But, I think it is not the best way to do it. I think the APIs can be more explicit regarding this. And, I think it is not future proof, since someday Game Freak can change the dependency of Beast Boost.

@phalt
Copy link
Member

phalt commented Apr 7, 2020

This is a good point. It shouldn't be hard to add this attribute to data currently. Feel free to make a pull request with changes and we can help review it and merge it.

@Naramsim
Copy link
Member

Adding a new flag is_beast would be easy but not maintainable. We rely on the data format decided by Veekun. They currently don't have any flag for identifying a beast pokemon. @nairraghav added successfully it to the CSV pokemon_species file but I asked him to remove it since this would break future updates from Veekun.

You could suggest over here to add the new property.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants