Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generation 8 BDSP doesn't have a Pokedex associated to the VersionGroup #948

Closed
TonyCollett opened this issue Nov 1, 2023 · 1 comment · Fixed by #998
Closed

Generation 8 BDSP doesn't have a Pokedex associated to the VersionGroup #948

TonyCollett opened this issue Nov 1, 2023 · 1 comment · Fixed by #998

Comments

@TonyCollett
Copy link

Similar issue to the other bug I reported, only simpler:

BDSP don't have a Pokedex associated to the Version Group

api/v2/version-group/brilliant-diamond-and-shining-pearl
Not sure if it should be 'original-sinnoh' or 'extended-sinnoh' or someething else

image
@TonyCollett TonyCollett changed the title Generation 8 BDSP don't have a Pokedex associated to the Version Group Generation 8 BDSP doesn't have a Pokedex associated to the VersionGroup Nov 1, 2023
@TonyCollett
Copy link
Author

I believe this is just updating pokedex_version_groups.csv with the following change:
pokedex_id: 5
version_group_id: 23

helblinglilly added a commit to helblinglilly/pokeapi that referenced this issue Jan 10, 2024
@helblinglilly
Add DP Pokedex to BDSP Version group
e9bbc6f 
This closes PokeAPI#948
@helblinglilly helblinglilly mentioned this issue Jan 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link BDSP and SWSH DLC Pokedexes with Version Groups helblinglilly/pokeapi
1 participant
@TonyCollett