Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen 8 & Hisui Location Area association #1005

Closed
wants to merge 2 commits into from

Conversation

DaltonSW
Copy link
Contributor

Now that there are assigned IDs for each 8/Hisui location, breaking those down into location areas to allow for encounter information... eventually

@DaltonSW
Copy link
Contributor Author

I'm committing/pushing these in small batches since I'm unfamiliar with the csv structure. I don't want to end up doing a mass amount of templating/editing for them to just not align, and only get that feedback after a PR. Also I figure getting some amount of new stuff in place would be better sooner rather than later, so others can start making use of it.

Let me know if y'all disagree with any of this, and I'm happy to change my commit/PR structure going forward. Not trying to clog stuff up here :)

@DaltonSW
Copy link
Contributor Author

Also, given the first bit, I would love if anybody is able to help me convert my web-scraped information into whatever format is necessary for encounter data. I'm frankly lost with where each piece of this information is saved, and in what format, but I think I've got a solid collection of the accurate data saved off

@Naramsim
Copy link
Member

Hi! Thanks for all the help! Working in small batches is the best so I can also understand what's going on 😅

@Naramsim
Copy link
Member

Also, given the first bit, I would love if anybody is able to help me convert my web-scraped information into whatever format is necessary for encounter data. I'm frankly lost with where each piece of this information is saved, and in what format, but I think I've got a solid collection of the accurate data saved off

This might be hard for me! I don't really play the new game and the mechanics might have changed. In the end it's all CSVs . I'll try to see if I can help you, but other people might be better at it

Copy link
Member

@Naramsim Naramsim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This data looks well formatted and clean! Did you scrape it off a website or off the game itself?

@DaltonSW
Copy link
Contributor Author

This might be hard for me! I don't really play the new game and the mechanics might have changed. In the end it's all CSVs . I'll try to see if I can help you, but other people might be better at it

That was one of the reasons I was trying to get into the Slack yesterday 😅

@DaltonSW
Copy link
Contributor Author

This data looks well formatted and clean! Did you scrape it off a website or off the game itself?

This was all pulled from PokeDB. I wrote a scraper bot that references this PokemonDB page, but I don't really trust my bot to pull everything and slap it in these CSVs properly without supervision right now. My commits for locations.csv and location_areas.csv were just hand-typed, referencing this page

I definitely don't plan on manually assembling the encounters and stuff, which is mostly why I wanted to get these IDs approved beforehand so I have a solid base to start assembling the rest of the data via script.

@DaltonSW
Copy link
Contributor Author

Apparently I closed this as completed somehow. I'm not very familiar with PRs and forked copies of repos and stuff. No idea how I did this...

@Naramsim any ideas what I messed up? Should I just redo the commit/PR?

@Naramsim
Copy link
Member

Hi! :) Don't worry :) Now I cannot reopen the PR, but I see you've created the new one.

BTW: thanks for the donation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants