Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding giants cap location, and gen 8 and hisui location areas #1009

Merged
merged 1 commit into from Jan 15, 2024

Conversation

DaltonSW
Copy link
Contributor

Submitting this again after I made a mistake on the last PR somehow

Adding Gen 8 and Hisui location areas to setup a baseline for adding encounter information

@Naramsim
Copy link
Member

I'll merge this in! If you spot mistakes in the future we can revert or change the data.

Are you able to build and test the API locally on your PC? That would help you understand the logic. So you can add the data and check if everything breaks and check the new data.

@Naramsim Naramsim merged commit 5993979 into PokeAPI:master Jan 15, 2024
3 checks passed
@DaltonSW
Copy link
Contributor Author

All the info on the last PR was correct, the "mistake" was that I somehow closed it prematurely by doing something that I thought was a necessary step. This is pretty much my first foray into PRs and public contribution, so I'm going through some growing pains 😅

@DaltonSW
Copy link
Contributor Author

I am able to build and test locally, and have been doing so, though frankly I'm not sure what exactly it's testing or doing to be confident that my changes got tested lol. I've looked through stuff overall, and I plan on doing so more in-depth before my big encounter adding endeavor, but I'm not sure I'm doing stuff 100% correct with the testing/building setup of this

@DaltonSW DaltonSW deleted the adding-location-areas branch January 15, 2024 19:03
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants