Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed overlap between locations and location areas with names #1012

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

DaltonSW
Copy link
Contributor

Due to the comment @Naramsim left on my other PR, I realized the additions I had made to location_areas resulted in duplicative information being returned in name elements. This is addressing that issue

@DaltonSW
Copy link
Contributor Author

I tried testing this more thoroughly, but I've been unable to get the local instance of PokeAPI running and updating with my changes when following the instructions on the README. If anyone would be able to help me with that, or update those docs, that would be great :)

@Naramsim Naramsim merged commit 19e8230 into PokeAPI:master Jan 20, 2024
3 checks passed
@Naramsim
Copy link
Member

Hi! Which setup have you followed? the python or the docker one?

Can you post here the error or where you're stuck?

@Naramsim
Copy link
Member

The procedure on the readme is complete and correct. I think

@DaltonSW
Copy link
Contributor Author

DaltonSW commented Jan 20, 2024

  • Could just be my ignorance with Docker, but I didn't know what to do after running make docker-setup. It definitely lists out how to start everything, but not how to get Docker to pull in any changes you make

  • When running without Docker, just using make serve, running make build-db didn't actually do anything on my system, and all of my API calls were returning a count of 0

  • There's no mention of make docker-build-db or make docker-test, I had to go into the Makefile to even see those were options I was missing out on calling.

  • make wipe_db isn't a valid command, it is now make wipe-sqlite-db. Again, had to find that by going into the Makefile to verify myself

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

@DaltonSW DaltonSW deleted the fix-location-area-names branch January 20, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants