Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activating Open Collective #295

Merged
merged 4 commits into from Jun 19, 2017
Merged

Conversation

xdamman
Copy link
Contributor

@xdamman xdamman commented Jun 16, 2017

This pull request adds backers and sponsors from your Open Collective https://opencollective.com/pokeapi ❤️

It adds two badges at the top to show the latest number of backers and sponsors. It also adds placeholders so that the avatar/logo of new backers/sponsors can automatically be shown without having to update your README.md. [more info]. See how it looks on this repo.
We have also added a postinstall script to let people know after npm|yarn install that you are welcoming donations (optional). [More info]
You can also add a "Donate" button to your website and automatically show your backers and sponsors there with our widgets. Have a look here: https://opencollective.com/widgets

P.S: As with any pull request, feel free to comment or suggest changes. The only thing "required" are the placeholders on the README because we believe it's important to acknowledge the people in your community that are contributing (financially or with code!).

Thank you for your great contribution to the open source community. You are awesome! 🙌
And welcome to the open collective community! 😊

Come chat with us in the #opensource channel on https://slack.opencollective.com - great place to ask questions and share best practices with other open source sustainers!

@phalt phalt requested review from zaneadix and Naramsim June 16, 2017 14:38
@phalt
Copy link
Member

phalt commented Jun 16, 2017

@Naramsim @zaneadix how do we feel about this? I am cool for it to be on the project.

@Naramsim
Copy link
Member

Naramsim commented Jun 16, 2017

Hi, the PR is ok, very good @xdamman.

However, I don't think we need the postinstall in our package.json, since this isn't actually a node/browser module that a user can install with Npm or Yarn. Whether you want to keep it or to leave it, LGMT.

@xdamman
Copy link
Contributor Author

xdamman commented Jun 16, 2017

Ah ok. Well it doesn't bother then ¯_(ツ)_/¯
And at least people who are curious and look into package.json will see that you have a collective :)

@phalt phalt merged commit b7175f7 into PokeAPI:master Jun 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants