Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SV learnset for Sinnoh starters #957

Merged
merged 1 commit into from Nov 12, 2023

Conversation

penelopeysm
Copy link
Contributor

I think these are the only Pokemon that were missed out in my previous PR (#920). I checked a couple of legendaries / mythicals and they have correct learnsets. However, do let me know if there are anything else that slipped through the cracks and I can run it again!

Closes #956

Copy link
Contributor

@giginet giginet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked your data in my script from 387 to 395. It works fine.

I appreciate your quick and great work. Thank you!

@giginet
Copy link
Contributor

giginet commented Nov 11, 2023

@Naramsim Could you check this PR?

@Naramsim Naramsim merged commit e6ba307 into PokeAPI:master Nov 12, 2023
2 checks passed
@Naramsim
Copy link
Member

Thanks @penelopeysm !

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

@penelopeysm penelopeysm deleted the sinnoh-starters branch November 12, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing move tables of 4th gen starter Pokémon
4 participants