Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add showdown field to pokemon api resource #978

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

FallenDeity
Copy link
Contributor

@FallenDeity FallenDeity commented Dec 16, 2023

This pr includes a new field in the pokemon endpoint which is the showdown field containing animated gif sprites for each pokemon.

This is a followup to this pr and #977 which was added a while back and allows these resources to be accessed from the api.

"showdown":{
            "front_default":"https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/other/showdown/1.gif",
            "front_shiny":"https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/other/showdown/shiny/1.gif",
            "front_female":null,
            "front_shiny_female":null,
            "back_default":"https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/other/showdown/back/1.gif",
            "back_shiny":"https://raw.githubusercontent.com/PokeAPI/sprites/master/sprites/pokemon/other/showdown/back/shiny/1.gif",
            "back_female":null,
            "back_shiny_female":null
         }

Above is the sample field after update and here is the data as a whole data.json

This pr also includes tests for the new addition here

self.assertEqual(
            sprites_data["other"]["showdown"]["front_default"],
            response_sprites_data["other"]["showdown"]["front_default"],
        )
        self.assertEqual(
            sprites_data["other"]["showdown"]["back_default"],
            response_sprites_data["other"]["showdown"]["back_default"],
        )

Copy link

@MakashiDev MakashiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good hope to see it integrated soon!

@Naramsim Naramsim merged commit 724f9bb into PokeAPI:master Dec 20, 2023
3 checks passed
@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Dec 21, 2023
@FallenDeity FallenDeity deleted the add-showdown-field-to-pokemon branch December 30, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants