Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

Introduce GitHub action #117

Merged

Conversation

giginet
Copy link

@giginet giginet commented Jul 21, 2022

Currently, this project doesn't have CI environments 馃

I recommend introducing CI environment strongly.

So I added GitHub Action environment instead of Travis CI.

This action runs some situations to dump Pok茅mon DB.

  • Run locally using all supported Pythons
  • Run on Docker Container

You have to merge #113 and #116 before to pass these jobs.

Please review them all 馃檹

)
if [ "$ENABLE_TTY" -ne 0 ]; then
options+=(-it)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub Action doesn't support TTY.
So on CI, -it has to be got rid of.

@Naramsim
Copy link
Member

Hi! thanks for the PR! It seems that there are some conflicts that cannot be resolved rising the UI. Could you have a look?

@giginet giginet force-pushed the support-github-action-for-pr2 branch from dbde654 to 2810724 Compare July 22, 2022 12:34
@giginet
Copy link
Author

giginet commented Jul 22, 2022

I fixed then it seems to pass all tests 馃尭

@giginet
Copy link
Author

giginet commented Jul 22, 2022

By the way, Can I be a maintainer of this repo?

Recently, I鈥檓 developing a Pok茅mon-related product as a hobby and I use this library.
I鈥檓 looking forward to Scarlet/Violet. I wish this repo is maintained for future series.

I鈥檓 a Pok茅mon trainer since the first series and I played Sword/Shield for over 1000 hours.
I can develop Python and some other programming languages.

Thank you.

@Naramsim
Copy link
Member

Hi, sorry, we don't really promote unknown people to the role of maintainer, this is for security reasons. Moreover, this is a fork of Veekun's project. We here, use it only for storing modified CSV files. I guess you are the only one using the Python engine.

@Naramsim Naramsim merged commit 19fa915 into PokeAPI:master-pokeapi Jul 22, 2022
@giginet giginet deleted the support-github-action-for-pr2 branch July 22, 2022 12:56
@giginet
Copy link
Author

giginet commented Jul 22, 2022

I understood. I use this library at my own risk. I wish for future developments.

@Naramsim
Copy link
Member

Yeahh, thanks for the contributions but I really doubt there will be any code updates other than to the CSV files :), from us.

But feel free to open as many PR as you want, I'll try to review and merge everything. If you commit, we could invite you as an external collaborator for this project so at least you'll have write access.

Also, I see that you are interested in the upcoming gen9. Are you planning to extract data from the games? If you do, we and Veekun would be really interested in it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants