V2Client cache-related methods #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cache_info_total - cache_clear_total - cache_location_absolute - Reworked logic used to check the V2Client cache parameter -
- Implemented: - - V2Client.cache_info - - V2Client.cache_clear - - V2Client.cache_location - caching wrapper function is now defined inside V2Client - get methods are counted when calling V2Client._assign_method
- base_get_test: clear cache before and after test - V2Client cache methods test: - - base_cache_info_test - - base_cache_clear_test - - base_cache_location_test
- V2Clint.cache_info() was incrementing cache size even when the cache of a specific get method was not growing
- Global cache hits and misses are now properly accounted for - Removed some unnecessary cache_clear() calls from the tests
This was referenced Feb 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.