Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evolve_all "all" is not working #2281

Closed
JSchwerberg opened this issue Aug 1, 2016 · 5 comments
Closed

evolve_all "all" is not working #2281

JSchwerberg opened this issue Aug 1, 2016 · 5 comments

Comments

@JSchwerberg
Copy link
Contributor

Expected Behavior

Bot would try to evolve all eligible pokemon when "evolve_all": "all" is set

Actual Behavior

Bot does not evolve anything when "evolve_all": "all" is set. If I set it to "evolve_all": "all,Weedle" I get the following output:

[19:11:08]  Starting PokemonGo Bot....
[19:11:09]  [x] Current egg hatches in 0.85 km
[19:11:10] [#] Successfully evolved Weedle with 180 CP and 0.4 IV!
[19:11:13] [#] Successfully evolved Weedle with 113 CP and 0.51 IV!

Steps to Reproduce

Set "evolve_all" to all on this commit

Other Information

OS: Ubuntu 14.04.4 LTS
Git Commit: eee7ba4
Python Version: python 2.7.6
@cadebrown
Copy link

Having this bug as well.

@OliverNicolini
Copy link

OliverNicolini commented Aug 2, 2016 •
edited
Loading

Last working commit 86472c0

@JSchwerberg JSchwerberg mentioned this issue Aug 2, 2016
Merged
@JSchwerberg
Copy link
Contributor Author

I've made pull request #2305 which fixes this -- if anyone wants to test and confirm, and comment over there, I'd appreciate it :)

@ewold
Copy link

ewold commented Aug 2, 2016 •
edited
Loading

The evolve worked but after evolving the bot didn't go back catching until i set evolve_all back to "NONE", anyone else has the same behaviour

@feydreva
Copy link

feydreva commented Aug 2, 2016

same issue on dev.
"evolve_all": "all" do not work
"evolve_all": "Rattata, Zubat" works fine

douglascamata pushed a commit that referenced this issue Aug 2, 2016
@JSchwerberg @douglascamata
Fix instance where evolve_all is unicode - fixes #2281 (#2305)
550b2c3 
* Fix instance where evolve_all is unicode

* Test for isinstance basestring rather than Unicode || str
mhdasding added a commit to mhdasding/PokemonGo-Bot that referenced this issue Aug 2, 2016
@mhdasding
Merge branch 'dev' into map_synergy
5fdc2e5 
* dev:
  Adapt code to new PGoApi Code (PokemonGoF#2357)
  Revert "[Feature] added keep pokemon for batch evolution" (PokemonGoF#2380)
  Revert "Dev Proxy support" (PokemonGoF#2374)
  Supporting sending requests through an HTTP proxy (PokemonGoF#2358)
  [Feature] added keep pokemon for batch evolution (PokemonGoF#2255)
  Fix instance where evolve_all is unicode - fixes PokemonGoF#2281 (PokemonGoF#2305)
  This is just a temp fix, The one added the configure param need make sure it's really work.
  Modify SpiralTask to use 70m as stepsize and diameter as step_count (PokemonGoF#2194)
  web submodule updated to latest commit (PokemonGoF#2289)
  added param in config.json.pokemon.example.
  Add missing curly bracket (PokemonGoF#2282)
  Update web to latest master commit (PokemonGoF#2274)
  Dev - Fixed the loss of fort data (updated) (PokemonGoF#2269)
  Add optional simple lure attraction feature (PokemonGoF#2257)
  [FIX] Improper use of exception  (PokemonGoF#2246)
  Change egg hatching text (PokemonGoF#2258)
coderplay pushed a commit to coderplay/PokemonGo-Bot that referenced this issue Aug 2, 2016
@JSchwerberg
Fix instance where evolve_all is unicode - fixes PokemonGoF#2281 (Pok…
71ec59f 
…emonGoF#2305)

* Fix instance where evolve_all is unicode

* Test for isinstance basestring rather than Unicode || str
coderplay pushed a commit to coderplay/PokemonGo-Bot that referenced this issue Aug 3, 2016
@JSchwerberg
Fix instance where evolve_all is unicode - fixes PokemonGoF#2281 (Pok…
c2a3f7b 
…emonGoF#2305)

* Fix instance where evolve_all is unicode

* Test for isinstance basestring rather than Unicode || str
coderplay pushed a commit to coderplay/PokemonGo-Bot that referenced this issue Aug 3, 2016
@JSchwerberg
Fix instance where evolve_all is unicode - fixes PokemonGoF#2281 (Pok…
463bb1b 
…emonGoF#2305)

* Fix instance where evolve_all is unicode

* Test for isinstance basestring rather than Unicode || str
MFizz pushed a commit to MFizz/PokemonGo-Bot that referenced this issue Aug 3, 2016
@JSchwerberg @MFizz
Fix instance where evolve_all is unicode - fixes PokemonGoF#2281 (Pok…
2c7aebc 
…emonGoF#2305)

* Fix instance where evolve_all is unicode

* Test for isinstance basestring rather than Unicode || str
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@JSchwerberg @OliverNicolini @feydreva @cadebrown @ewold