Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase default walking speed #1574

Closed
wants to merge 2 commits into from
Closed

Increase default walking speed #1574

wants to merge 2 commits into from

Conversation

Bashin
Copy link
Contributor

@Bashin Bashin commented Jul 29, 2016

Short Description:
Walking speed was changed from m/s to km/h, so i updated the config files to match the old default speed.

@Jojo1910
Copy link

Isn´t 14 km/h the perfect speed for eggs?

@Bashin
Copy link
Contributor Author

Bashin commented Jul 29, 2016

Maybe.. I just converted 4.16 m/s to 15 km/h (multiplied by 3.6)

@douglascamata
Copy link
Member

@Bashin StepWalker consider the speed in m/s, because our distance functions returns in meters:

distance(
            self.initLat,
            self.initLng,
            destLat,
            destLng
        )

@Bashin
Copy link
Contributor Author

Bashin commented Jul 29, 2016

Are you sure about that? -> #1570
Wiki says km/h too

@Nihisil
Copy link
Contributor

Nihisil commented Jul 29, 2016

I put 14 to the config and bot started to walk really fast (to compare with previous walk speed).

And with this speed eggs still hatching.

@Bashin
Copy link
Contributor Author

Bashin commented Jul 29, 2016

I put 15 to the config and if you compare distance traveled and time it has to be km/h.
Egg hatching works for me too

@MikeDX
Copy link
Contributor

MikeDX commented Jul 29, 2016

If you set a higher speed, it may still not work depending upon location - also the egg hatching distance count may not match the actual distance the bot has travelled.

Using a higher value in speed in one location allowed eggs to be hatched at a fairly regular place, but in another, the bot ran for a while and the counter did not go up, with the only difference in config being the location.

@douglascamata
Copy link
Member

douglascamata commented Jul 29, 2016

We can't exactly tell how fast the bot is walking, because we make some API calls and have to sleep a lot of time, so it's clearly visible that we're NEVER walking at the speed we think to.

Don't think of walking speed as a unit (m/s or km/h), just know that bigger is faster and smaller if slower.

@Bashin
Copy link
Contributor Author

Bashin commented Jul 29, 2016

Ok, but the default value is really slow (i get about 4 km/h after a lot of calculating)

@douglascamata
Copy link
Member

@Bashin 4 km/h is a very human-like walking. We want to provide a default value close to human walking, so it's good.

@maestroi
Copy link
Contributor

don't increase default walking speed because in europe i you walk to fast it does not hatch, 4km/h is pretty much a good speed, also there is no use to go faster.

@douglascamata
Copy link
Member

Closing because the default value should definitely be human-like.

@Bashin
Copy link
Contributor Author

Bashin commented Jul 29, 2016

It works for me in europe.. I think you could double the default value without getting any problems and it's still a very human-like value.

@maestroi
Copy link
Contributor

normal average walking speed is like 5km/h so would be very strange if u walk like 8 that's pretty quick for walking 6 hours straight especially if you look at a phone screen.

@A7F
Copy link

A7F commented Jul 29, 2016

i set the speed on 13 and still hatch eggs... i still don't get wether is in km/h or m/s btw works (Europe, Italy)
If the speed is intended in km/h it's still reasonable just because you can move by bike

@Bashin
Copy link
Contributor Author

Bashin commented Jul 29, 2016

I think its very reasonable too, but it's ok for me if the value remains as it is (maybe round it to 4 or 5). The wiki should be updated anyway. I'll set walk to 10 in my config as it is working for me an there is still a safety margin up to 14 or 15.
Any chance to get editor rights for the wiki?

@Bashin Bashin mentioned this pull request Jul 29, 2016
hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this pull request Sep 28, 2016
* .gitignore doesn't ignore these because they exist
* move them to example files that users can copy to non-example
  files which gitignore will now ignore
* if the user didn't copy and modify them before running the app,
  do the the courtesy of copying the configs in for them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants