Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unicode issues #1817

Closed
wants to merge 2 commits into from
Closed

fix unicode issues #1817

wants to merge 2 commits into from

Conversation

CapCap
Copy link
Contributor

@CapCap CapCap commented Jul 30, 2016

Short Description:

Fixes:

- #1814

@CapCap CapCap closed this Jul 30, 2016
@CapCap CapCap reopened this Jul 30, 2016
@vieira
Copy link
Contributor

vieira commented Jul 30, 2016

The problem is that the log function is sometimes called with an already decoded utf8 str while some other times it is called with an unicode sequence that needs to be decoded before print.

def log(string, color='white'):
    try:
        string = string.decode('utf8')
    except UnicodeEncodeError:
        pass

<rest of the original code>

This is enough to fix the problem and make log work with both str and unicode sequences.

@DayBr3ak
Copy link
Contributor

190640f makes this irrelevant

@vieira
Copy link
Contributor

vieira commented Jul 30, 2016

@DayBr3ak still getting errors if the initial location contains any special characters.

@vieira
Copy link
Contributor

vieira commented Jul 30, 2016

#1825 should fix the issue with the initial location.

hoanghuynh pushed a commit to hoanghuynh/PokemonGo-Bot that referenced this pull request Sep 28, 2016
* prevent multiple map-updates

In case a map-update took longer than 5s, multiple updates were started, this is a simple fix so there is always only one map-update running

* updated formatting

* updated formatting ^2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants