Removed the old inventory / only one call to the api

[BriceSD]

Short Description:

I’m making the next step toward the new inventory integration.
I’ve deleted every call to the old one, as well as uneeded refresh call.
For now I’ve only tested the item part. I definitely need help to test these changes.

[BriceSD]

@Moonlight-Angel If you got any idea about it :)

[johannlejeune]

@BriceSD I don't know if we can avoid calling the API for the player stats. Are they stored and correctly updated internally ? In which case we could use the internally stored info instead of calling the API.
If no such thing is available, then I guess the same kind of refactoring is necessary to get the player data once and update it internally.

[BriceSD]

@Moonlight-Angel It doesn’t track player stats. After putting some thought in it, I think it shouldn’t after all. We don’t even make an api call each tick, making one hear is completely fine. The fact that it’s called get_inventory() confused me.

But what about moving these to metrics, I can see a use for them somewhere else :

        current_level = int(player_stats.get('level', 0))
        prev_level_xp = int(player_stats.get('prev_level_xp', 0))
        next_level_xp = int(player_stats.get('next_level_xp', 0))
        experience = int(player_stats.get('experience', 0))
        current_level_xp = experience - prev_level_xp
        whole_level_xp = next_level_xp - prev_level_xp

edit : we need some of them at start up.

[TheSavior]

It's probably best to just remove code rather than comment it out.

[BriceSD]

Agreed, still got some clean up to do

[julienlavergne]

The issue now that we have full cached inventory is:

• Your bot can be detected by renaming / transferring / evolving pokemon without ever refreshing the inventory. If it is what the mobile app is doing, then fine, otherwise you are flagged. It would be good to know what the app is doing exactly.
• The web inventory is never updated

[julienlavergne]

Not like that ;) candy object is used right after

[BriceSD]

The way I understand it we’re printing the updated amount of candies right after. Updating it before seems legit.

[achretien]

Pretty sure you can get the exact number of awarded candies in the return API call (currently 3 but could change in the future)

[julienlavergne]

What I mean is that the add function does not return a candy object instance.

[BriceSD]

@anakin5 Oh I understand what you mean now

[BriceSD]

It’s right, they could know that we’re using a bot since we don’t refresh the inventory.
But this has always been the case. The bot has never make the same calls in the same order as the app. For now they don’t look at these stats to bann/softbann.

[julienlavergne]

I consider it a defect if the bot does not do the same thing as the app.

[douglascamata]

@anakin5 I consider it a defect if the bot does not do the same thing as the app.

Then we are full of defects.

We need to refresh the inventory only one single time at every tick and it's ok.

[TheSavior]

Are we still waiting on changes for this PR? Or is this good to go?

[BriceSD]

@TheSavior Now that I know what I want to do about UpdateLiveStats, we’re very close to it. Got few things to do, I got some refactoring in mind but that will happen in an other PR.

[BriceSD]

@TheSavior @douglascamata Should be good now

[douglascamata]

@BriceSD merge conflicts :P

[solderzzc]

Still have conflict...

[BriceSD]

I found that on PokemonCatchWorker

        is_vip = self._is_vip_pokemon(pokemon)
        if pokeballs < 1:
            if superballs < 1:
                if ultraballs < 1:
                    return WorkerResult.SUCCESS
                if not is_vip:
                   return WorkerResult.SUCCESS

If I remember well we are suppose to use ultraball on non VIP too, depending on min_ultraball_to_keep. Can someone confirm these last 2 lines shouldn’t be there ?

[solderzzc]

@BriceSD you are right, and we already save lots of ultra ball since the new configuration.

[BriceSD]

@solderzzc Thanks, I removed them from PokemonCatchWorker as well as MoveToMapPokemon

[solderzzc]

@BriceSD Great, let's merge this PR in.

[Gobberwart]

An issue from this appears to be that the inventory only updates when recycle_items runs (ie. if available space <= min_empty_space), which could be hours between refreshes depending on how your bot is configured. The inventory should update via the API run every tick, or at least every minute or so to prevent any incorrect information.

Note also that the web/inventory-USERNAME.json file only updates when the inventory refreshes, so this is effectively useless at the moment.

[Gobberwart]

#4417