Added Total Stardust to UpdateLiveStats task #5874
Conversation
|
@pogarek, thanks for your PR! By analyzing the history of the files in this pull request, we identified @AdaptCharm, @Moonlight-Angel and @brantje to be potential reviewers. |
|
I don't how to fix line 30 in tests/update_live_stats_test.py to pass the test.. |
|
I've created a fix for the test for you, you can check it out at my fork of your fork. I will let you edit your own fork so you can understand exactly what happened. However, if you want I can just submit a pull request to your fork. Summary of changes pokemongo_bot/cell_workers/update_live_stats.py # From
total_stardust = int(self.bot.stardust)
# to
total_stardust = int(metrics.stardust)tests/update_live_stats_test.py line 17: # added
'total_stardust'
# to config['stats'] list.line 187 and 188: # added
'Total Stardust: 1'
# to expected. |
|
thanks, @nelsyeung ! So using metrics class was the way to go :) Changes are commited now, thanks a lot!! |
|
I don't play anymore so can't test |
|
@brantje lol, I don't have a usable hash key, so I can only review and merge w/o testing.. |
|
👍 |
* Added Total Stardust to UpdateLiveStats task (#5874) * added Total Stardust to UpdateLiveStats task * fixes to tests, thanks to @nelsyeung * enabled option to log to file (#5881) * Fixes #5883 (#5884) This fixes an issue when you have a brand new account (no stardust yet) and run the bot. This makes sure the key is there before we do something with it. * removing proto and protobuf and changing pogoapi to dev * removing proto and protobuf, changing pogoapi to dev branch, fixing docs and install scripts
* Proto requirements fix (#5888) * Added Total Stardust to UpdateLiveStats task (#5874) * added Total Stardust to UpdateLiveStats task * fixes to tests, thanks to @nelsyeung * enabled option to log to file (#5881) * Fixes #5883 (#5884) This fixes an issue when you have a brand new account (no stardust yet) and run the bot. This makes sure the key is there before we do something with it. * removing proto and protobuf and changing pogoapi to dev * removing proto and protobuf, changing pogoapi to dev branch, fixing docs and install scripts * Prevent bouncing between 2 forts Added simple logic to prevent bouncing between 2 forts when using Polyline walker * Original fixes by Anakin5 Original PR by Anakin5 which fixes the following: #5407 Fix step walker timing issue. This solve some problems where we were moving more than the configured speed from time to time. Improve a bit the computation speed of step_walker get_next_step pep8 fixes * Prevent bouncing between 2 forts Added simple logic to prevent bouncing between 2 forts when using Polyline walker
Now you can have Total Stardust if UpdateLiveStats task is enabled. Just add "total_stardust" to stats property in task configuration in your configuration file.