Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove duplicates in swshp.json #338

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Conversation

phiilu
Copy link
Contributor

@phiilu phiilu commented Jan 24, 2023

I noticed that SWSH294, SWSH295, SWSH296, SWSH297 and SWSH298 were added twice in the swshp.json. I removed the ones without the artist.

@jonnyBohnanny
Copy link

For SWSH296 at least both copies were incomplete one had a regulationMark and the other had artist, neither had both I think I'm working off of 900f7b8

https://github.com/phiilu/pokemon-tcg-data/blob/1e77a74996533d2ae7d3e1b5f5820ce5ec099597/cards/en/swshp.json#L18399-L18407

@phiilu
Copy link
Contributor Author

phiilu commented Apr 25, 2023

@adback03 anything wrong with the PR? I am happy to update it

@adback03 adback03 merged commit b157d21 into PokemonTCG:master Jun 1, 2023
Pepper0ni pushed a commit to Pepper0ni/pokemon-tcg-data that referenced this pull request Jan 31, 2024
* remove duplicate SWSH294, SWSH295, SWSH296, SWSH297, SWSH298

* remove duplicate rule in SWSH296
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants