Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes to cel25c #348

Merged
merged 7 commits into from
Feb 16, 2023
Merged

Conversation

Cealgair
Copy link
Contributor

@Cealgair Cealgair commented Jan 29, 2023

I added "Pokémon-GX rule: " to cel25c-60_A's rules. It was the only (non-tag team) Pokémon-GX that did not have that at the beginning of the rules.

@Cealgair Cealgair changed the title Added "Pokémon-GX rule: " to cel25c-60_A's rules Various fixes to cel25c-60_A's rules Jan 29, 2023
@Cealgair Cealgair marked this pull request as draft January 29, 2023 16:14
@Cealgair
Copy link
Contributor Author

I've noticed there are plenty more inconsistencies with rules in that set, I will add them to this PR

@Cealgair Cealgair changed the title Various fixes to cel25c-60_A's rules Various fixes to cel25c's rules Jan 29, 2023
@Cealgair
Copy link
Contributor Author

Okay so I noticed there was a lot to fix in that set. You can see what I did from the commit descriptions. There are a couple of things I noticed that I didn't fix here, but I fixed them in #341 and #347

@Cealgair Cealgair marked this pull request as ready for review January 29, 2023 17:57
@Cealgair Cealgair changed the title Various fixes to cel25c's rules Various fixes to cel25c Jan 29, 2023
@@ -653,7 +664,7 @@
"Psychic"
],
"rules": [
"When a Pokémon-ex has been knocked out, your opponent takes 2 Prize cards."
"When Pokémon-ex has been knocked out, your opponent takes 2 Prize cards."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be this: Pokémon-EX rule: When a Pokémon-EX has been Knocked Out, your opponent takes 2 Prize cards.

@@ -713,7 +724,7 @@
],
"evolvesFrom": "Kirlia",
"rules": [
"When a Pokémon-ex has been knocked out, your opponent takes 2 Prize cards."
"When Pokémon-ex has been knocked out, your opponent takes 2 Prize cards."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here: Pokémon-EX rule: When a Pokémon-EX has been Knocked Out, your opponent takes 2 Prize cards.

@Cealgair
Copy link
Contributor Author

Cealgair commented Jan 31, 2023

I disagree with both revisions, for the following reasons:

  • The rule on the card is written without the 'a'. I agree that it would be better if it was written with it, but it's not
  • All other Pokémon-ex (from the ex era) already have the rules without the 'a'. To check this, you can use the query subtypes:ex rules:"when a pokemon-ex" -set.id:"bw*" -set.id:"xy*" -set.id:g1
  • All of the Pokémon-EX (from bw/xy) have the rules with the 'a'. To check this, you can use the query subtypes:ex rules:"when pokemon-ex" -set.id:"ex*" -set.id:"pop*" -set.id:np

EDIT: for good measure, one can also check using the queries subtypes:ex -rules:"when a pokemon-ex" (set.id:"bw*" OR set.id:"xy*" OR set.id:g1) and subtypes:ex -rules:"when pokemon-ex" (set.id:"ex*" OR set.id:"pop*" OR set.id:np)

@Cealgair Cealgair mentioned this pull request Feb 5, 2023
@adback03 adback03 merged commit a056b77 into PokemonTCG:master Feb 16, 2023
@Cealgair Cealgair deleted the celebrations_tapulele branch February 16, 2023 12:59
Pepper0ni pushed a commit to Pepper0ni/pokemon-tcg-data that referenced this pull request Jan 31, 2024
* Added "Pokémon-GX rule: " to cel25c-60_A's rules

* Fixed rules of cel25-93_A and cel25c-88_A

* Fixed rules and Poké-Power of cel25-17_A

* Changed [C] to C and Garchomp to Garchomp C in cel25-145_A; [GL] to GL and Luxray to Luxray GL in cel25c-109_A

* Added "Pokémon-EX Rule: " to the rules of cel25c-54_A, cel25c-97_A and cel25c-76_A

* Added missing levels to cel25c

* Added missing flavor texts to cel25c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants