Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vignette | Ambiguous Wording and Code #55

Closed
ChristophLeonhardt opened this issue Jan 31, 2024 · 1 comment
Closed

Vignette | Ambiguous Wording and Code #55

ChristophLeonhardt opened this issue Jan 31, 2024 · 1 comment

Comments

@ChristophLeonhardt
Copy link

ChristophLeonhardt commented Jan 31, 2024

I noticed two instances in which the vignette is ambiguous, both in scenario 1:

  • there is a character vector containing the names of structural attributes, but when the corpus is encoded, the parameter s_attributes is set to character() instead
    • Note: in this scenario, it is also likely that the encoding of the structural attribute "id" will fail as the column in the metadata object contains integers instead of characters
  • when encoded, the compression argument is set to FALSE, but the text assumes that the argument is set to TRUE
@ablaette
Copy link
Collaborator

Perfectly valid - I have changed the vignette accordingly (using s_attributes, compress = TRUE).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants