Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

troubleshoot local Data Source Details link #151

Closed
3 of 4 tasks
Tracked by #163
josh-chamberlain opened this issue Dec 20, 2023 · 2 comments · Fixed by #171
Closed
3 of 4 tasks
Tracked by #163

troubleshoot local Data Source Details link #151

josh-chamberlain opened this issue Dec 20, 2023 · 2 comments · Fixed by #171
Assignees
Labels
bug Something isn't working

Comments

@josh-chamberlain
Copy link
Contributor

josh-chamberlain commented Dec 20, 2023

Context

Discord thread

We held back Data Source Details from the 2023 app launch because we couldn't get links from search results to load the detail pages—probably some kind of environment config issue. This was working while deployed, but not locally.

Screen Shot 2023-12-20 at 11 11 47 AM

↑ (local dev branch) http://localhost:5174/data-sources/rec09GnLmHWnRE3NJ

Screen Shot 2023-12-20 at 11 12 56 AM

↑ (deployed dev branch) https://data-sources.pdap.dev/data-sources/rec09GnLmHWnRE3NJ

Issues

  • clicking "view source details" from the currently commented-out button on the SearchResultCard component should lead to a working source detail page.
    • note: it will still be ugly if it works, because the styles haven't been touched since a bunch of custom styles were removed.
  • when I load sources directly, they have all null values: https://data-sources.pdap.io/data-sources/recPdBv9M0QhyKKZN

Tests

  • make sure this works on local and deployed branch before it goes to main

Docs

  • if this is a local config issue, we should tell people how to set up their environment in the README
@josh-chamberlain
Copy link
Contributor Author

@mbodeantor would you be able to look at this? the ability to link people to specific sources would be great.

@joshuagraber
Copy link
Contributor

We'll need to merge #169 to dev just to make sure, but all other requirements have been confirmed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants