Add last cached value to data source query #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
Fix url breaking, add support for last archived, add button to go to Internet Archive
Update test for DataSourceStaticView, update various snapshots
|
For next week: this is now ready for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #179 when merged to main
Description
Add
last_cachedto the values to query in the API for the GET data sources by id endpoint. I noticed a small bug in how the arguments were passed to the data sources by id endpoint query, which I fixed as well.To test changes in the UI:
Testing links:
With
last_archivedproperty: http://localhost:5173/data-sources/rec1EBIuvKwEl3oKLWith
readme_urlproperty: http://localhost:5173/data-sources/rec2tMlGKrNnXlsQoDocs
Docs updated in this PR