Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: create extendable eslint config #44

Merged
merged 11 commits into from
Jan 30, 2024
Merged

feature: create extendable eslint config #44

merged 11 commits into from
Jan 30, 2024

Conversation

joshuagraber
Copy link
Collaborator

@joshuagraber joshuagraber commented Jan 9, 2024

Resolves #40

To test already-implemented eslint config (This has already been published as a sub-package, @pdap-design-system/eslint-config)

  1. Visit this PR to data-sources
    and observe successful linting workflow run.
  2. To test locally, check out the PR, cd client and npm run lint.
  3. To test IDE integration, ensure you're using VS Code or another editor that has eslint and prettier extensions configured. In any js or vue file, find a string with single quotes and change it to use double quotes. Save the file. Ensure the string is auto-formatted to use single quotes again.

@joshuagraber joshuagraber marked this pull request as ready for review January 25, 2024 14:27
@josh-chamberlain
Copy link
Contributor

I'm stuck at step 3 — I'm reasonably sure I know what "add eslint" means but I definitely don't know what "Extend @pdap-design-system/eslint-config" means. Perhaps having Marty review would make more sense?

@joshuagraber
Copy link
Collaborator Author

@josh-chamberlain Yes, I can see how this is unclear, sorry about that. And really, following the instructions in that issue is probably overkill for testing this anyways. I'll update in the morning with simpler, clearer AC.

@joshuagraber joshuagraber self-assigned this Jan 26, 2024
@joshuagraber
Copy link
Collaborator Author

@josh-chamberlain @mbodeantor updated the testing steps. Given that I already published the sub-package to npm and integrated into my PR to data-sources for linting and client stuff in CI, the results of this PR are observable in my PR there.

@joshuagraber joshuagraber changed the title refactor: create extendable eslint config feature: create extendable eslint config Jan 26, 2024
@mbodeantor mbodeantor merged commit 24233e5 into main Jan 30, 2024
5 checks passed
@mbodeantor mbodeantor deleted the extend-eslint branch January 30, 2024 15:50
Copy link

🎉 This PR is included in version 2.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Export eslint config for use in other client apps
3 participants