-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: create extendable eslint config #44
Conversation
Add workspaces field
I'm stuck at step 3 — I'm reasonably sure I know what "add eslint" means but I definitely don't know what "Extend @pdap-design-system/eslint-config" means. Perhaps having Marty review would make more sense? |
@josh-chamberlain Yes, I can see how this is unclear, sorry about that. And really, following the instructions in that issue is probably overkill for testing this anyways. I'll update in the morning with simpler, clearer AC. |
@josh-chamberlain @mbodeantor updated the testing steps. Given that I already published the sub-package to |
🎉 This PR is included in version 2.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Resolves #40
To test already-implemented eslint config (This has already been published as a sub-package,
@pdap-design-system/eslint-config
)data-sources
and observe successful linting workflow run.
cd client
andnpm run lint
.eslint
andprettier
extensions configured. In anyjs
orvue
file, find a string with single quotes and change it to use double quotes. Save the file. Ensure the string is auto-formatted to use single quotes again.