Add common font between all headers #1700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anth-volk
requested changes
May 6, 2024
There was a problem hiding this comment.
Thanks for this, @rhwd. This does do exactly what the issue says, but would you mind also changing the "fontWeight" property in the src/modals/SigupModal file from "bold" to "500" to match other fonts? The modal still looked incorrect and it appears that's also part of the problem.
|
Thanks for the heads up and instructions, @anth-volk. Just pushed a fix for this. |
anth-volk
approved these changes
May 6, 2024
There was a problem hiding this comment.
This is perfect! Thanks @rhwd. Will merge once the GitHub Actions finish.
In the future, we typically recommend that contributors fork our repo, then keep their master branch up to date with the live branch, making edits on a local feature branch. Instructions on how to do so are available in our README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A small fix for #1699
Changes
Added the h5, and h6 elements to the existing CSS rule for headers