MI income tax difference with TAXSIM35

[martinholmer]

The following integration test fails. It is not yet known whether the
tax logic problem is in TAXSIM35 or in the current PEUS code, or
whether there are problems in both models. This topic is meant to
facilitate discussion of why this test fails, primarily by reporting
the results of hand calculations required to fill out the relevant tax
form.

- name: Tax unit with taxsimid 97725 in h21.its.csv and h21.ots.csv
  absolute_error_margin: 0.01
  period: 2021
  input:
    people:
      person1:
        age: 37
        employment_income: 31010
        taxable_interest_income: 5505.0
        short_term_capital_gains: 5005.0
        rental_income: 2505.0
        rent: 23000
        ssi: 0  # not in TAXSIM35
        state_supplement: 0  # not in TAXSIM35
        wic: 0  # not in TAXSIM35
        ma_covid_19_essential_employee_premium_pay_program: 0  # not in TAXSIM35
      person2:
        age: 37
        employment_income: 4010
        taxable_interest_income: 5505.0
        short_term_capital_gains: 5005.0
        rental_income: 2505.0
        ssi: 0  # not in TAXSIM35
        state_supplement: 0  # not in TAXSIM35
        wic: 0  # not in TAXSIM35
        ma_covid_19_essential_employee_premium_pay_program: 0  # not in TAXSIM35
    tax_units:
      tax_unit:
        members: [person1, person2]
        premium_tax_credit: 0  # not in TAXSIM35
        local_income_tax: 0  # not in TAXSIM35
        state_sales_tax: 0  # not in TAXSIM35
        ca_use_tax: 0  # not in TAXSIM35
        il_use_tax: 0  # not in TAXSIM35
        nm_2021_income_rebate: 0  # not in TAXSIM35
        nm_additional_2021_income_rebate: 0  # not in TAXSIM35
        nm_supplemental_2021_income_rebate: 0  # not in TAXSIM35
        ny_supplemental_eitc: 0  # not in TAXSIM35
        ok_use_tax: 0  # not in TAXSIM35
        pa_use_tax: 0  # not in TAXSIM35
        vt_renter_credit: 0  # not in TAXSIM35
    spm_units:
      spm_unit:
        members: [person1, person2]
        snap: 0  # not in TAXSIM35
        tanf: 0  # not in TAXSIM35
    households:
      household:
        members: [person1, person2]
        state_fips: 26  # MI
  output:  # expected results from patched TAXSIM35 2024-03-06 version
    mi_income_tax: 2178.13

[Mshuning]

@PavelMakarchuk The reason for this difference seems to be that the calculation of mi_household_resources did not include short_term_capital_gains. The results from TAXSIM35 and PEUS will be the same after short_term_capital_gains is added into mi_household_resources.

[PavelMakarchuk]

Thank you! Should we be including those according to the tax form? If so, could you file an issue and make the adjustment

[PavelMakarchuk]

@martinholmer this will be fixed by #4104