This repository has been archived by the owner on Oct 17, 2018. It is now read-only.
Deal with smartTag and links with multiple runs #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
added 3 commits
March 21, 2013 18:33
…) and links with multiple runs
…un tags. In addition did some code cleanup.
| @@ -749,6 +755,8 @@ def get_relationship_info(tree, media, image_sizes): | |||
| continue | |||
| # Store the target in the result dict. | |||
| target = el.get('Target') | |||
| if any(target.lower().endswith(ext) for ext in ['emf', 'wmf', 'svg']): | |||
There was a problem hiding this comment.
The update note should mention we're now ignoring these images and this should be a constant that's declared and commented as far as why they're ignored.
There was a problem hiding this comment.
Need a test that these are ignored.
|
Dealt with @winhamwr review notes, merging this into master |
jlward
added a commit
that referenced
this pull request
Mar 22, 2013
Deal with smartTag and links with multiple runs
| # hyperlink tag with its child run tag. | ||
| child_run_tag = el.find('%sr' % w_namespace) | ||
| if child_run_tag is None: | ||
| # hyperlink tags with its child run tag. |
There was a problem hiding this comment.
Read this again. We're getting child run tags (multiple)
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
…) and links with multiple runs
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
…un tags. In addition did some code cleanup.
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
pushed a commit
that referenced
this pull request
Mar 14, 2014
jlward
added a commit
that referenced
this pull request
Mar 14, 2014
Deal with smartTag and links with multiple runs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.