Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for observing ancsAuthorized property on peripheral. #370

Merged
merged 6 commits into from
Aug 28, 2020
Merged

Added support for observing ancsAuthorized property on peripheral. #370

merged 6 commits into from
Aug 28, 2020

Conversation

radumvlad
Copy link
Contributor

Added support for ancsAuthorized property that was introduced in iOS 13: https://developer.apple.com/documentation/corebluetooth/cbperipheral/3180040-ancsauthorized

@CLAassistant
Copy link

CLAassistant commented May 6, 2020

CLA assistant check
All committers have signed the CLA.

@radumvlad
Copy link
Contributor Author

CI will continue failing since it is using XCode 10.2. Not sure if there's anything I can do for this.

@minixT
Copy link
Collaborator

minixT commented Aug 21, 2020

CI will continue failing since it is using XCode 10.2. Not sure if there's anything I can do for this.

Please update .travis.yml and use xcode11.6 osx_image. This should fix problems with failing build.

Copy link
Collaborator

@minixT minixT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for you PR. Please update travis configuration to fix build problems.

@minixT
Copy link
Collaborator

minixT commented Aug 21, 2020

I'm already working on updating our CI configuration. Please wait until I finish this. After that I'll merge your PR.

@radumvlad
Copy link
Contributor Author

Unfortunately, generate-mocks.sh only uses iPhone sdk, but not also macOS sdk. I tried changing the script, but just changing the sdk_path doesn't seem to do it, so it beats me. For now I manually added an #if !macOS so the tests run accordingly.

@radumvlad radumvlad requested a review from minixT August 27, 2020 11:53
@minixT
Copy link
Collaborator

minixT commented Aug 27, 2020

Unfortunately, generate-mocks.sh only uses iPhone sdk, but not also macOS sdk. I tried changing the script, but just changing the sdk_path doesn't seem to do it, so it beats me. For now I manually added an #if !macOS so the tests run accordingly.

I'm working on changes in the generate-mocks.sh script to fix this problem I hope I will manage to complete this soon.

@radumvlad
Copy link
Contributor Author

Thank you @minixT , I will leave this to you.

@minixT
Copy link
Collaborator

minixT commented Aug 27, 2020

@radumvlad I've updated generate-mocks.sh script. Please merge current master branch and regenerate mocks. It should resolve your problems.

@minixT minixT merged commit 7c48869 into Polidea:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants