Feature/plmc 412 on initialize benchmarks #159
Conversation
automatic hrmp connection working Genesis instantiator usage and first draft of HRMP connection formatting feature propagation cleanup new node functioning. genesis not yet sure if working new node functioning. genesis not yet sure if working somehow compiling and test passing save save save feat(287): para_id setting extrinsic implemented and tested save same log crate across workspace same log crate across workspace save save save feat(287): changed tight couple of pallet_xcm by extracting sender trait feat(287): first commit feat(285): POC Hrmp automatic acceptance
# Conflicts: # Cargo.lock # Cargo.toml # integration-tests/src/tests/mod.rs # pallets/funding/Cargo.toml # pallets/funding/src/functions.rs # pallets/funding/src/instantiator.rs # pallets/funding/src/lib.rs # pallets/funding/src/mock.rs # pallets/funding/src/types.rs # pallets/xcm-executor/src/config.rs # pallets/xcm-executor/src/lib.rs # runtimes/standalone/src/lib.rs # runtimes/testnet/src/xcm_config.rs
…s-polimecs-balance-and-pallet # Conflicts: # Cargo.toml
… new map of query id -> unconfirmed transactions
Signed-off-by: Juan Ignacio Rios <juani.rios.99@gmail.com>
Signed-off-by: Juan Ignacio Rios <juani.rios.99@gmail.com>
Signed-off-by: Juan Ignacio Rios <juani.rios.99@gmail.com>
JuaniRios
force-pushed
the
feature/plmc-412-on_initialize-benchmarks
branch
from
30bd050
to
37e7848
Compare
# Conflicts: # Cargo.lock # pallets/funding/src/benchmarking.rs # pallets/funding/src/functions.rs # pallets/funding/src/instantiator.rs # pallets/funding/src/lib.rs # pallets/funding/src/mock.rs # pallets/funding/src/tests.rs # pallets/funding/src/weights.rs # runtimes/testnet/src/lib.rs
# Conflicts: # pallets/funding/src/benchmarking.rs # pallets/funding/src/functions.rs # pallets/funding/src/tests.rs # runtimes/base/src/lib.rs # runtimes/testnet/src/xcm_config.rs
Signed-off-by: Juan Ignacio Rios <juani.rios.99@gmail.com>
Signed-off-by: Juan Ignacio Rios <juani.rios.99@gmail.com>
Signed-off-by: Juan Ignacio Rios <juani.rios.99@gmail.com>
There was a problem hiding this comment.
Logic looks good to me with a couple of comments. One more general comment would be around all the unwraps in instantiator/benchmarks/tests. Might be good to handle them (where making sense) more gracefully. Had some tests failing in previous PR with big panic around unwrap on error. Better to handle it properly.
Signed-off-by: Juan Ignacio Rios <juani.rios.99@gmail.com>
…ight functions Signed-off-by: Juan Ignacio Rios <juani.rios.99@gmail.com>
What would you suggest is a better way to handle it? |
Could do "expect("some useful error message")" instead of unwrap? Could also do assert!(result.is_ok()). |
assert_ok would do the same as unwrap, in that it will panic with the error type. We could do a new PR where we replace the unwraps with expects explaining the possible causes for that panic. But lets not do it here |
What?
Add the benchmarks for all the functions called inside on_initialize. Make them as accurate as possible as in #148
Why?
on_initialize needs to know the exact weight consumed to let the rest of the extrinsics execute.
If it's inaccurate, we risk never producing blocks in the worst case, or consuming all the block space and having no space for extrinsics.
How?
Same as #148
Testing?
Same as #148
Screenshots (optional)
Anything Else?