feature/plmc-486-change-is_funded-to-use-usd-amounts-of-evaluations-instead #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-amounts-of-evaluations-instead # Conflicts: # integration-tests/src/tests/credentials.rs # pallets/funding/src/functions.rs # pallets/funding/src/instantiator.rs # pallets/funding/src/lib.rs # pallets/funding/src/tests.rs
lrazovic
approved these changes
Mar 26, 2024
JuaniRios
deleted the
feature/plmc-486-change-is_funded-to-use-usd-amounts-of-evaluations-instead
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
use the usd amount bonded at the time of evaluating for calculating if a project reached the threshold for passing to the funding round
Why?
Using the plmc price at the time of ending the evaluation opens us up for an exploit on the exchanges
How?
use the field in
ProjectDetailsevaluation_round_info.total_bonded_usdTesting?
pallet test
plmc_price_change_doesnt_affect_evaluation_endAnything else?
Changed the const price provider to use a
thread_local!key for the price map so we can change the price.